-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lint cleanup #127
Lint cleanup #127
Conversation
Unlikely this will ever be an issue, but probably would perfer it to be an explicit error since it would indicate another more serious issue is going on.
@Ben-PH feel free to review too! (Github won't let me add you as a reviewer) |
6f563c7
to
0b9ceec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it.
Minor, inconsequential nit, but the map_or_else functions might be able to use Path::display
(similar to "instead of |s| s.to_string()
, use str::to_string
"), but you do you.
0b9ceec
to
13e4a61
Compare
Not seeing a way to do that without dropping the |
Missed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Based on #124, but this time fewer pedantic lint fixes and cleaner git history.