-
-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nix pills #153
Nix pills #153
Conversation
Previous behavior added an extra `../` to the path, which works on web (extra ../'s get removed once it gets to the root) but broke locally.
@edolstra the Pills have all been ported. This is fully Ready To Go! |
Please hold, actually. Verifying some changes to the makefile. |
Ok, the patches I've made fix an issue where realpath failed if the website hadn't been generated before. Now it works OK and should be 🆗 |
layout.tt
Outdated
@@ -59,6 +61,7 @@ | |||
<ul class="dropdown-menu"> | |||
<li><a href="[%root%]">NixOS</a></li> | |||
<li><a href="[%root%]nix">Nix</a></li> | |||
<li><a href="[%root%]nix-pills">Nix Pills</a></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems strange to put this in the drop down menu as a top-level project. Shouldn't it just be linked from the docs page?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be, I wasn't sure which top level project it would belong to for the menu, and was worried about it being confusing to click docs in nix/nixpkgs/nixos and end up in a different section. Then I put it in its own section. What do you recommend?
I moved the pills to nixos/support |
Previous behavior added an extra
../
to the path, which works on web(extra ../'s get removed once it gets to the root) but broke locally.
When there are navigation links in docbook, present the top and bottom links
Distribute the Nix Pills on the website
The about 60% of the nix pills have been ported to docbook. You could merge this now, or wait until they're fully ported. Also, of course, if you wish I did this differently, that'd be fine too :)