Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --filename flag for overriding the filename when using stdioTarget #264

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

pluiedev
Copy link
Contributor

When --filename path is specified, any diagnostics will use the path instead of <stdin>.

Closes #263

Copy link

github-actions bot commented Nov 21, 2024

Nixpkgs diff

@pluiedev pluiedev changed the title Add --filename flag for overriding the filename when using stdinTarget Add --filename flag for overriding the filename when using stdioTarget Nov 21, 2024
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Needs a treefmt to satisfy CI though :)

When `--filename path` is specified, any diagnostics will use the
`path` instead of `<stdin>`.

Closes NixOS#263
@pluiedev
Copy link
Contributor Author

Just did :D

@tomberek tomberek merged commit 923d379 into NixOS:master Nov 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add a flag for overriding the filename of files passed through stdin
3 participants