[OPS-1448] Replace buildkite with github actions #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #119 |
rvem
approved these changes
Sep 27, 2023
|
Don't forget to remove buildkite check from required and add |
Lucus16
suggested changes
Oct 5, 2023
.github/workflows/main.yml
Outdated
| run: nix shell .#packages.x86_64-linux.reuse -c reuse lint | ||
|
|
||
| - name: build | ||
| run: nix build .#nixfmt-static |
There was a problem hiding this comment.
Probably should check that .#nixfmt-webdemo and .#nixfmt-deriver build as well though I'm not sure what the latter is. Maybe .#awscli too to be sure that the deploy action will work after nixpkgs upgrades. Put them all in separate checks if possible.
There was a problem hiding this comment.
Added checks for nixfmt-webdemo and awscli. nixfmt-deriver is a nix expression generated by cabal2nix, it was pushed into cachix, which I guess no one uses. I also added hlint and stylish-haskell checks, but decided not to apply the changes to avoid large rebases in other pull requests.
Lucus16
approved these changes
Oct 9, 2023
Problem: The current buildkite-based ci is being replaced with github actions. Solution: Add github ci config, remove buildkite config.
Sereja313
force-pushed
the
sereja/OPS-1448-bk-to-ga
branch
from
1a8132b
to
1100f8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: The current buildkite-based ci is being replaced with github actions.
Solution: Add github ci config, remove buildkite config.