flakeref: follow symlinks #9499
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roberth
reviewed
Nov 30, 2023
Co-authored-by: Robert Hensing <[email protected]>
|
I was about to open a PR with the same change. This PR, if merged, would fix #8013. |
|
I think this is a good and simple change. One thing I would suggest is adding a functional test for this. Have a look at this section of the manual for info on how to set this up. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2024-03-11-nix-team-meeting-132/42960/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #9463
Motivation
Given
/tmp/flakelinkis a symlink to an actual flake directory, currently this happens:This PR attempts to fix that.
Warning: I have no prior knowledge of the nix-codebase or much of a background in C++. Please review carefully. In particular, I do not know if there's any ramification, regarding the use of
flakerefin theinputsdefinitions offlake.nixfiles or other edge-cases. @infinisil and @YorikSar pressured me into this 😉Priorities
Add 👍 to pull requests you find important.