Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 7447 to 2.13 maintenance #8763

Merged
merged 3 commits into from
Aug 7, 2023
Merged

Backport 7447 to 2.13 maintenance #8763

merged 3 commits into from
Aug 7, 2023

Conversation

roberth
Copy link
Member

@roberth roberth commented Jul 31, 2023

Motivation

Solve the issue raised in

Context

Closes #8392 which I couldn't force push

Checklist for maintainers

Maintainers: tick if completed or explain if not relevant

  • agreed on idea
  • agreed on implementation strategy
  • tests, as appropriate
    • functional tests - tests/**.sh
    • unit tests - src/*/tests
    • integration tests - tests/nixos/*
  • documentation in the manual
  • documentation in the internal API docs
  • code and comments are self-explanatory
  • commit message explains why the change was made
  • new feature or incompatible change: updated release notes

Priorities

Add 👍 to pull requests you find important.

aakropotkin and others added 3 commits July 31, 2023 16:37
@aakropotkin @roberth
primop: add readFileType, optimize readDir
1a6446b 
Allows checking directory entry type of a single file/directory.

This was added to optimize the use of `builtins.readDir` on some
filesystems and operating systems which cannot detect this information
using POSIX's `readdir`.

Previously `builtins.readDir` would eagerly use system calls to lookup
these filetypes using other interfaces; this change makes these
operations lazy in the attribute values for each file with application
of `builtins.readFileType`.

(cherry picked from commit 153ee46)
@roberth
rl-next.md: Minor improvement
1dfcf41 
(cherry picked from commit 37c533e)
@roberth
Fixup release notes (NixOS#8393)
995b658 
* Fixup release notes
@Ericson2314
Copy link
Member

I guess it is OK to skip some releases to backport since this is not a behavioral change?

@roberth
Copy link
Member Author

roberth commented Jul 31, 2023

It is not a behavior change except for builtins?readFileType which is not part of our implicit compatibility promise.

Also it can be argued to fix the buggy lib.pathType polyfill. If not technically buggy it is at least confusing, and that's worth fixing too.
It sure beats documenting and communicating the "limitations" of 23.05.

@Ericson2314
Copy link
Member

oh my bad I think i was looking at the wrong diff. If this is alreaydd in 2.14 (or 2.15 cause 2.14 is kinda of informally deprecated) no problem.

@infinisil
Copy link
Member

Btw I implemented a very hacky workaround for it here: https://github.com/NixOS/nixpkgs/pull/222981/files#diff-c7ec15b333bb1ce2cb8065610ad1952b59fbb0fa244cf272c12b7e020c2fa146L37-R86

@edolstra edolstra merged commit 5bc21dc into NixOS:2.13-maintenance Aug 7, 2023
@infinisil infinisil mentioned this pull request Dec 8, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fricklerhandwerk fricklerhandwerk Awaiting requested review from fricklerhandwerk fricklerhandwerk is a code owner

@edolstra edolstra Awaiting requested review from edolstra edolstra is a code owner

@thufschmitt thufschmitt Awaiting requested review from thufschmitt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@roberth @Ericson2314 @infinisil @edolstra @aakropotkin