-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically document builtin constants #8330
Conversation
While I certainly agree we should have this systematically and automatically documented, I'm not sure if we should actually expose null, true, false and the hidden constants. In general, maybe it's better to leave things undocumented rather than having a non-informative one-liner until we have something sensible. If we wait until we collect information on all of them, the PR will become really large and possibly run into merge conflicts. |
@fricklerhandwerk you can replace the strings will I personally like the fact that even |
a5a4c5e
to
3d05484
Compare
Exposing
|
Triaged in Nix team meeting 2023-05-19:
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2023-05-19-nix-team-meeting-minutes-56/28446/1 |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2023-06-05-nix-team-meeting-minutes-60/28933/1 |
3d05484
to
ba7bd90
Compare
542ff91
to
323efdb
Compare
323efdb
to
4ba15c2
Compare
46608c6
to
ec96c6e
Compare
1fdcf36
to
7ecb072
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for stalling this. This PR is a huge improvement.
5fb31db
to
27081d4
Compare
c812ebb
to
99ee579
Compare
Any primop will do for this, so might as well use one that isn't impure. Co-authored-by: Robert Hensing <[email protected]>
b5aaf8d
to
cca8b59
Compare
Co-authored-by: Robert Hensing <[email protected]>
This is done in roughly the same way builtin functions are documented. Also auto-link experimental features for primops, subsuming PR #8371. Co-authored-by: Eelco Dolstra <[email protected]> Co-authored-by: Robert Hensing <[email protected]> Co-authored-by: Valentin Gagarin <[email protected]>
7fa6140
to
22b278e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/tweag-nix-dev-update-50/29793/1 |
This is done in roughly the same way builtin functions are documented.
Also auto-link experimental features for primops, subsuming PR #8371.
Motivation
Keeping the documention with the code like this makes it much easier to ensure it stays up to date and in sync.
Context
Recent doc PRs alerted me to the fact that we didn't yet have this infrastructure.
I moved in the existing docs, and then wrote some rough placeholder sentences for the others.
Checklist for maintainers
Maintainers: tick if completed or explain if not relevant
tests/**.sh
src/*/tests
tests/nixos/*
Priorities
Add 👍 to pull requests you find important.