Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fish 2.11 #7040

Merged
merged 2 commits into from
Sep 14, 2022
Merged

Fish 2.11 #7040

merged 2 commits into from
Sep 14, 2022

Commits on Sep 14, 2022

  1. Add fish suport to installer

    Before this patch, installing Nix using the Fish shell did not
    work because Fish wasn't configured to add Nix to the PATH. Some
    options in NixOS#1512 offered workarounds, but they typically involve
    extra plugins or packages.
    
    This patch adds native, out-of-the-box support for the Fish shell.
    
    Note that Fish supports a `conf.d` directory, which is intended
    for exactly use cases like this: software projects distributing
    shell snippets. This patch takes advantage of it. The installer
    doesn't append any Nix loader behavior to any Fish config file.
    Because of that, the uninstall process is smooth and a reinstall
    obliterates the existing nix.fish files that we place instead of
    bothering the user with a backup / manual removal.
    
    Both single-user and multi-user cases are covered. It has been
    tested on Ubuntu, and a Mac with MacPorts, homebrew, and the
    Fish installer pkg.
    
    Closes NixOS#1512
    
    Co-authored-by: Graham Christensen <[email protected]>
    (cherry picked from commit 8ebdbeb)
    Hoverbear authored and grahamc committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    0dfdd21 View commit details
    Browse the repository at this point in the history
  2. Add installer_test matrix for shells

    Signed-off-by: Ana Hobden <[email protected]>
    (cherry picked from commit 7194c87)
    Hoverbear authored and grahamc committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    0481be8 View commit details
    Browse the repository at this point in the history