-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parallel tests fixes #3778
Parallel tests fixes #3778
Conversation
(waiting for the CI to confirm the OSX fix as I can't test it locally) |
Maybe we can use relative paths when we create the socket to get around this? |
4c37fcb
to
26ca796
Compare
I tried that but it's not allowed I managed to work around the path length by directly putting the daemon socket under Now I'm stuck again with a non-sensical error on the OSX builder 😠 (the |
Mh, the same pipeline passed on Tweag's repo (https://github.com/tweag/nix/runs/833213722). I'll try force-pushing to restart the pipeline and see if the failure persists |
26ca796
to
06bcd93
Compare
Reuse the pre-existing list rather than the one written as part of NixOS#3777
Fix a socket length failure on the OSX builders
06bcd93
to
223fbe6
Compare
Looks like there is also a dependency on |
Yup', I've also restored it in this branch The OSX failure now seems to be a real one introduced by 5596f87 (I've tried rebasing it on top of yesterday's master removing the "parallel tests" MR, and it still fails: https://github.com/tweag/nix/runs/833623967) |
Fix the issues introduced by #3777
tests/plugins/libplugintest.*
as a dependency of the testsuitesocket path is too long
error on the OSX builders