Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installer: also test for xz to unpack #3431

Merged
merged 1 commit into from
Mar 21, 2020

Conversation

pmiddend
Copy link

As mentioned in #3430, we are checking for tar, and then use -J to unpack the xz file. But this needs xz, too!

@domenkozar domenkozar merged commit 7bc1961 into NixOS:master Mar 21, 2020
@pmiddend pmiddend deleted the install-script-test-for-xz branch March 21, 2020 09:54
@LnL7
Copy link
Member

LnL7 commented May 27, 2020

On some platforms, like darwin, tar supports lzma commpression without having xz available as a command. This change makes the command mandatory which means people would have to install another package manager to make that available first.

$ xz --help
The program 'xz' is currently not installed. You can install it
by typing:
  nix-env -iA nixpkgs.lzma.bin

$ /usr/bin/tar -v -xJf nix-2.3.5-x86_64-darwin.tar.xz -C /tmp
x nix-2.3.5-x86_64-darwin/install
x nix-2.3.5-x86_64-darwin/create-darwin-volume.sh
x nix-2.3.5-x86_64-darwin/install-darwin-multi-user.sh
x nix-2.3.5-x86_64-darwin/install-systemd-multi-user.sh
x nix-2.3.5-x86_64-darwin/install-multi-user
...
     -J, --xz
             (c mode only) Compress the resulting archive with xz(1).  In extract or list modes, this option is
             ignored.  Note that, unlike other tar implementations, this implementation recognizes XZ compression auto-
             matically when reading archives.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/trouble-installing-nix-on-ubuntu-20-04-3-lts/15085/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants