nix-util / meson: Add -latomic on arm #11540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I couldn't get the test program to work correctly after many attempts, so let's just unblock this without making it perfect.
roberth
added
the
build-problem
|
This also applies to riscv. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2024-09-18-nix-team-meeting-minutes-179/52361/1 |
|
@NickCao are you sure? The cross build to riscv just works |
|
Doesn't seem to be needed for armv7 (since all the Hydra builds succeed)? OTOH it probably doesn't hurt. |
Strange, I had to add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The meson build did not get this flag right yet, for the armv6/7 builds.
I couldn't get the test program to work correctly after many attempts, so let's just unblock this without making it perfect.
Context
https://hydra.nixos.org/build/272876163/nixlog/1
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.