-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add outputHashMode
argument attribute to bulitins that could support it
#10480
Labels
language
The Nix expression language; parser, interpreter, primops, evaluation, etc
Milestone
Comments
Ericson2314
added
the
language
The Nix expression language; parser, interpreter, primops, evaluation, etc
label
Apr 11, 2024
Ericson2314
added a commit
to obsidiansystems/nix
that referenced
this issue
Apr 13, 2024
Code operating on store objects (including creating them) should, in general, use `ContentAddressMethod` rather than `FileIngestionMethod`.
Ericson2314
added a commit
to obsidiansystems/nix
that referenced
this issue
Apr 13, 2024
Code operating on store objects (including creating them) should, in general, use `ContentAddressMethod` rather than `FileIngestionMethod`. See also dfc8765 which included some similar refactors.
Not sure.
Possible use case:
|
roberth
changed the title
Add
Add Apr 14, 2024
outputHashMode
arugment attribute to bulitins that oculd support itoutputHashMode
argument attribute to bulitins that could support it
Good point with |
Ericson2314
added a commit
to obsidiansystems/nix
that referenced
this issue
May 17, 2024
Code operating on store objects (including creating them) should, in general, use `ContentAddressMethod` rather than `FileIngestionMethod`. See also dfc8765 which included some similar refactors.
roberth
added a commit
that referenced
this issue
May 20, 2024
Slight refactors in preparation for #10480
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
An output
outputHashMode
argument attribute should be supported by all ofbuiltins.derivation
builtins.path
builtins.fetchTree
builtins.fetchurl
In order to specify which
ContentAddressMethod
is used for creating store paths.Misc notes:
For
builtins.derivation
this is specifying that for a content addressed (fixed or floating) derivation output, for the other two, it is specifying that for the store path the builtin creates directly.With lazy trees,
builtins.fetchTree
may not longer create a path. Perhaps paths created from it still turn into store objects, and it would affect those. Or maybe it's just better to separate concerns and not have this argument onbuiltins.fetchTree
after all.The text was updated successfully, but these errors were encountered: