-
-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tutorials: Map Module #820
tutorials: Map Module #820
Conversation
Propagate the changes made in a previous code snippet to this code snippet. Primarily fixing the poorly referenced ``${geocode``. Signed-off-by: Brian McGillion <[email protected]>
Adjust the functionality to reference geocode correctly and also to make sure of the correct escaping formats. Signed-off-by: Brian McGillion <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks a lot!
You know what would be really neat if you're still motivated and have time? If the scripts would be full derivations at the download location. Then we don't have to spend readers' brain power on explaining them and just assign the output of import (fetchTarball ...)
.
Sure, I can. Time is a bit limited, hence the 3-hour tutorial was spread over 3/4 days. But I can take a look. |
@fricklerhandwerk I am having an issue understanding why it is not lexing the code block starting on line 948. Taking that block into a |
Co-authored-by: Valentin Gagarin <[email protected]>
Fixed the formatting. The problem may have been nesting quotes, but not sure. |
Finish the tutorial, and update some snippets to be consistent with the previously made ones.
Fix some geocode references.
Full implementation according to the tutorial, maps-module, for reference.