Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add guide on post build hook #528

Merged

Conversation

fricklerhandwerk
Copy link
Collaborator

Closes #463

originally written under LGPL 2.1 for the Nix reference manual.
authors as recorded in the Nix repository:

git log --pretty="Co-authored-by: %an <%ae>" -- doc/manual/advanced-topics/post-build-hook.xml doc/manual/src/advanced-topics/post-build-hook.md | sort | uniq

relicenced with authors' permission to CC-BY-SA 4.0: #463

@fricklerhandwerk fricklerhandwerk added the guide Topics for a new guides label Feb 7, 2024
@infinisil
Copy link
Member

Now that the CLA is gone, it seems fine to proceed with this. @fricklerhandwerk sound good?

@fricklerhandwerk
Copy link
Collaborator Author

fricklerhandwerk commented Mar 7, 2024

Yeah, it just needs to be finished (i.e. review pass, add links to the Nix manual, check that it actually works, etc.). Free for grabs really, my queue is way too long to ever terminate anyway.

@proofconstruction
Copy link
Contributor

Rebased this and fixed some of the links (and the errors due to the vale check I didn't notice before), but now linkcheck fails in an unrelated file due to NixOS/nixos-homepage#1448; pausing this while that's sorted.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2024-05-31-documentation-team-meeting-notes-130/46261/1

fricklerhandwerk and others added 5 commits June 3, 2024 08:17
originally written under LGPL 2.1 for the Nix reference manual.
authors as recorded in the Nix repository:

    git log --pretty="Co-authored-by: %an <%ae>" -- doc/manual/advanced-topics/post-build-hook.xml doc/manual/src/advanced-topics/post-build-hook.md | sort | uniq

relicenced with authors' permission to CC-BY-SA 4.0: NixOS#463

Co-authored-by: Eelco Dolstra <[email protected]>
Co-authored-by: Graham Christensen <[email protected]>
Co-authored-by: Joe Hermaszewski <[email protected]>
Co-authored-by: Kevin Stock <[email protected]>
Co-authored-by: endgame <[email protected]>
Co-authored-by: regnat <[email protected]>
Co-authored-by: wamirez <[email protected]>
Co-authored-by: Valentin Gagarin <[email protected]>
@proofconstruction proofconstruction marked this pull request as ready for review June 3, 2024 15:43
@proofconstruction proofconstruction requested a review from a team as a code owner June 3, 2024 15:43
@proofconstruction proofconstruction marked this pull request as draft June 3, 2024 15:53
@proofconstruction proofconstruction marked this pull request as ready for review June 4, 2024 06:12
@proofconstruction proofconstruction merged commit 143d6c0 into NixOS:master Jun 4, 2024
5 checks passed
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2024-06-03-documentation-team-meeting-notes-131/46810/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
guide Topics for a new guides
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Nix post-build hooks
4 participants