Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add first build information in section of working with local files #1025

Merged
merged 3 commits into from
Jul 25, 2024

Conversation

YSawc
Copy link
Contributor

@YSawc YSawc commented Jul 24, 2024

- In union working section of Working with local files, code difference is not clearly written so fix it.

@YSawc YSawc requested a review from a team as a code owner July 24, 2024 23:01
@YSawc YSawc force-pushed the fix-union-working-diff branch from 2f50dfb to 8235176 Compare July 24, 2024 23:18
@YSawc YSawc force-pushed the fix-union-working-diff branch from 8235176 to 5a1989a Compare July 24, 2024 23:22
@@ -366,17 +366,31 @@ One way to fix this is to use [`unions`](https://nixos.org/manual/nixpkgs/stable

Create a file set containing a union of the files to exclude (`fs.unions [ ... ]`), and subtract it (`difference`) from the complete directory (`./.`):

```{code-block} nix
```{code-block} diff
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't always have to make it a difference. There's no firm rule, but I tried making it a diff where it's a small change - in order to highlight that - and have a full file, like here, where it's essentially a new thing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

11c9f26
Ok, I remove code defferences and change the description of PR.

@YSawc YSawc changed the title Add code difference in union working section. Add first build information in section of working with local files Jul 25, 2024
@YSawc YSawc requested a review from fricklerhandwerk July 25, 2024 10:35
Copy link
Collaborator

@fricklerhandwerk fricklerhandwerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time! Every little fix makes the next person's journey a bit easier

@fricklerhandwerk fricklerhandwerk enabled auto-merge (squash) July 25, 2024 12:55
@fricklerhandwerk fricklerhandwerk merged commit d554da9 into NixOS:master Jul 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants