Use system clock for local offset, not timekeeping #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szszszsz
added a commit
that referenced
this pull request
Jun 18, 2019
Allow TOTP implementation to work with timestamps beyond 2038 From #90: > This uses the system clock for storing the offset since the last update only. Unix timestamp of the set_time command is stored locally as u64 to prevent year 2038 integer overrun and added to current local offset for TOTP generation. > Passes https://github.com/Nitrokey/libnitrokey/blob/0275ebc610b255e3519baf866438244f288576bc/unittest/test_pro.py#L456 now. Fixes #17 Fixes #90
|
Merged, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the system clock for storing the offset since the last update only.
Unix timestamp of the
set_timecommand is stored locally asu64to prevent year 2038 integer overrun and added to current local offset for TOTP generation.resolves #17
Firmware:
firmware.zip