Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check length of comment before saving #224

Merged
merged 1 commit into from
Apr 11, 2024
Merged

check length of comment before saving #224

merged 1 commit into from
Apr 11, 2024

Conversation

jj-so
Copy link
Contributor

@jj-so jj-so commented Mar 12, 2024

Check the length of the comment if it is too long to save, the Save button is disabled and the info_box displays "Comment is too long".

Closes #223

@daringer
Copy link
Collaborator

lgtm

@jj-so jj-so merged commit efaf067 into main Apr 11, 2024
20 checks passed
@jj-so jj-so deleted the comment branch April 11, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Too long comments can not be saved secrets: Improve input validation
2 participants