Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Nitrokey Pro 0.8 #53

Merged
merged 43 commits into from
Dec 12, 2016

Conversation

szszszsz
Copy link
Member

@szszszsz szszszsz commented Dec 12, 2016

All devices pass the tests: Pro 0.7, 0.8, Storage 0.43
Tested under Ubuntu 16.10 with: Clang++ 3.8. Tested compilation also on G++ 6.2.

Support for Nitrokey Pro 0.8:

  • new authorization mechanism
  • longer OTP secrets

Additional tests:

  • longer secrets
  • start secret with null value
  • write all OTP slots and check returned code (confirm with oath library)

Ability to skip the test if the device does not support it.
Assumed features for Pro 0.8 will be available in Storage 0.44

for commands EraseSlot, WriteToSlot, GetCode + tests

Signed-off-by: Szczepan Zalega <[email protected]>
Signed-off-by: Szczepan Zalega <[email protected]>
To allow read-only backward compatibility for GET_CODE

Signed-off-by: Szczepan Zalega <[email protected]>
Signed-off-by: Szczepan Zalega <[email protected]>
Authenticate before testing invalid hex strings
Remove invalid test for empty string for writing otp slot (empty string allows editing)

Signed-off-by: Szczepan Zalega <[email protected]>
@szszszsz szszszsz force-pushed the nk_pro_0.8_authorization_fix-longer_secret branch from a0622da to 5e02e1e Compare December 12, 2016 14:15
@szszszsz szszszsz merged commit ed5044d into master Dec 12, 2016
@szszszsz szszszsz deleted the nk_pro_0.8_authorization_fix-longer_secret branch December 12, 2016 16:06
@szszszsz szszszsz mentioned this pull request Dec 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant