Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 31 secret as hex #36

Merged
merged 4 commits into from
Sep 10, 2016
Merged

Issue 31 secret as hex #36

merged 4 commits into from
Sep 10, 2016

Conversation

szszszsz
Copy link
Member

@szszszsz szszszsz commented Sep 9, 2016 •
edited
Loading

Fixes #31
Works already. Tested under Ubuntu 16.04 with py.test -v run in unit_tests directory.
Need to:

  • check from security perspective
  • check border conditions
  • remove assertions in favor of throwing exceptions
  • clean code if needed

Breaking change:

  • secrets sent to write OTP slots has to be now coded in hex (without 0x prefix)

@szszszsz szszszsz force-pushed the issue_31-secret_as_hex branch from 9eed6d6 to 99fdad7 Compare September 9, 2016 14:43
@szszszsz
C++ test update (compilation fix)
9d84244 
Signed-off-by: Szczepan Zalega <[email protected]>
@szszszsz
Add hex to binary converting function
77ea27f 
Signed-off-by: Szczepan Zalega <[email protected]>
@szszszsz
Assume secret is coded in hex for OTP slot write #31
3632e8a 
Signed-off-by: Szczepan Zalega <[email protected]>
@szszszsz
Remove asserts in favor of exceptions or warnings. Test changes in Py…
a46491a 
…thon.

On possible data truncation return LibraryError(exception) instead of silently truncating and logging warning

Signed-off-by: Szczepan Zalega <[email protected]>
@szszszsz szszszsz force-pushed the issue_31-secret_as_hex branch from 99fdad7 to a46491a Compare September 10, 2016 08:53
@szszszsz szszszsz changed the title [WiP] Issue 31 secret as hex Issue 31 secret as hex Sep 10, 2016
@szszszsz
Copy link
Member Author

Full test suite passes on NK Pro v0.7, Ubuntu 16.04.
If secret is shorter than 20 bytes, the rest are 0s.

@szszszsz szszszsz merged commit b16e89a into master Sep 10, 2016
@szszszsz szszszsz deleted the issue_31-secret_as_hex branch September 10, 2016 09:02
sgued pushed a commit to sgued/libnitrokey that referenced this pull request Feb 14, 2022
@conorpp
Merge pull request Nitrokey#36 from Nitrokey/bootloader-related
182b91f 
Allow to specify end app page in the signature making
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pass binary data (OTP secrets) coded as hex values
1 participant
@szszszsz