Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check why packet buffers are not zeroed #8

Closed
szszszsz opened this issue Apr 19, 2016 · 1 comment
Closed

Check why packet buffers are not zeroed #8

szszszsz opened this issue Apr 19, 2016 · 1 comment

Comments

@szszszsz
Copy link
Member

szszszsz commented Apr 19, 2016 •
edited
Loading

Buffers of each packet should be zeroed while creating. To check why they are not.
Check #7 / #9
@szszszsz
Copy link
Member Author

szszszsz commented Aug 1, 2016

It has appeared that while whole packet was zeroed on initialization, the payload copied was not. Currently implemented get_payload() convinience function as fix.

@szszszsz szszszsz closed this as completed Aug 1, 2016
sgued pushed a commit to sgued/libnitrokey that referenced this issue Feb 14, 2022
@nickray
Merge pull request Nitrokey#8 from solokeys/option_bytes
fd8d8f6 
rewrite option bytes on detach if needed
sgued pushed a commit to sgued/libnitrokey that referenced this issue Feb 14, 2022
@daringer
fixed bad isort/black calls, see Nitrokey#8
a835af5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@szszszsz