Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake doesn't install any headers #70

Closed
ignatenkobrain opened this issue Oct 7, 2017 · 2 comments
Closed

cmake doesn't install any headers #70

ignatenkobrain opened this issue Oct 7, 2017 · 2 comments

Comments

@ignatenkobrain
Copy link
Contributor

There is

file(GLOB LIB_INCLUDES "include/libnitrokey/*.h")
install (FILES ${LIB_INCLUDES} DESTINATION "include")

in the CMakeLists.txt, but there is basically no libnitrokey directory, so cmake doesn't install any header files..
@ignatenkobrain
Copy link
Contributor Author

@szszszsz thanks a lot!

I submitted review request for inclusion of libnitrokey into Fedora (https://bugzilla.redhat.com/show_bug.cgi?id=1499408) and hopefully soon I will update nitrokey-app in Fedora to the latest version.

Thanks again!

@szszszsz
Copy link
Member

szszszsz commented Oct 7, 2017

My pleasure! Feel free to let me know if there are any other issues with making packages.
And thank you for updating it!

sgued pushed a commit to sgued/libnitrokey that referenced this issue Feb 14, 2022
@daringer
Merge pull request Nitrokey#70 from robin-nitrokey/nethsm-commands-2
790e8e3 
Add more nethsm subcommands
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ignatenkobrain @szszszsz