175 ecdsa in bbf #219
175 ecdsa in bbf #219
Conversation
AntoineCyr
force-pushed
the
175-ecdsa-in-bbf
branch
4 times, most recently
from
c1c2887 to
de33e2d
Compare
Clang Test Results 168 files +4 168 suites +4 15m 26s ⏱️ -6s For more details on these errors, see this check. Results for commit 6237adf. ± Comparison against base commit 04a9a94. ♻️ This comment has been updated with latest results. |
Gcc Test Results 167 files +4 167 suites +4 16m 20s ⏱️ +3s For more details on these errors, see this check. Results for commit f8768f3. ± Comparison against base commit 1fed3a7. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
I am not sure that requested changes are sufficient, but I do believe they are necessary. I also think that more comments (i.e. moving some of the documentation from Notion into code) could benefit flexible_multiplication code. It was pretty useless with the old syntax, but now should be rather helpful.
crypto3/libs/algebra/include/nil/crypto3/algebra/fields/field.hpp
Outdated
Show resolved
Hide resolved
crypto3/libs/algebra/include/nil/crypto3/algebra/curves/detail/vesta/types.hpp
Outdated
Show resolved
Hide resolved
crypto3/libs/multiprecision/include/nil/crypto3/multiprecision/detail/endian.hpp
Outdated
Show resolved
Hide resolved
crypto3/libs/blueprint/test/bbf/algebra/fields/non_native/flexible_multiplication.cpp
Outdated
Show resolved
Hide resolved
crypto3/libs/blueprint/test/bbf/algebra/fields/non_native/flexible_multiplication.cpp
Outdated
Show resolved
Hide resolved
...t/include/nil/blueprint/bbf/components/algebra/fields/non_native/flexible_multiplication.hpp
Show resolved
Hide resolved
...t/include/nil/blueprint/bbf/components/algebra/fields/non_native/flexible_multiplication.hpp
Outdated
Show resolved
Hide resolved
...t/include/nil/blueprint/bbf/components/algebra/fields/non_native/flexible_multiplication.hpp
Outdated
Show resolved
Hide resolved
AntoineCyr
force-pushed
the
175-ecdsa-in-bbf
branch
5 times, most recently
from
32b71c2 to
53c3f17
Compare
…timizations to the created circuit.
AntoineCyr
force-pushed
the
175-ecdsa-in-bbf
branch
from
53c3f17 to
eeaafc6
Compare
AntoineCyr
force-pushed
the
175-ecdsa-in-bbf
branch
2 times, most recently
from
f8768f3 to
86f5bed
Compare
AntoineCyr
force-pushed
the
175-ecdsa-in-bbf
branch
from
86f5bed to
6237adf
Compare
No description provided.