Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiprecision refactoring: inverse mod and big_int improvements, checked big_uint operations #214

Merged
merged 46 commits into from
Dec 23, 2024

Conversation

ioxid
Copy link
Contributor

@ioxid ioxid commented Dec 18, 2024

Also general cleanup, more tests and fixes, zkevm_word rewrite, making all internal operations private, and many refactorings.

@ioxid ioxid force-pushed the multiprecision-refactoring-step-3 branch 2 times, most recently from dd5d873 to 4ab0dc5 Compare December 18, 2024 16:34
Copy link

github-actions bot commented Dec 18, 2024

Clang Test Results

  160 files   -   1    160 suites   - 1   15m 27s ⏱️ - 1m 14s
7 276 tests +190  7 270 ✅ +190  6 💤 ±0  0 ❌ ±0 
7 350 runs  +178  7 344 ✅ +178  6 💤 ±0  0 ❌ ±0 

Results for commit 08bd958. ± Comparison against base commit 9b3fb27.

This pull request removes 3012 and adds 3202 tests. Note that renamed tests count towards both.
addition ‑ wraps
addition ‑ wraps_rev
fields_manual_tests.test_comparison_128_256 ‑ _0
fields_manual_tests.test_comparison_128_256 ‑ _1
fields_manual_tests.test_comparison_128_256 ‑ _10
fields_manual_tests.test_comparison_128_256 ‑ _100
fields_manual_tests.test_comparison_128_256 ‑ _101
fields_manual_tests.test_comparison_128_256 ‑ _102
fields_manual_tests.test_comparison_128_256 ‑ _103
fields_manual_tests.test_comparison_128_256 ‑ _104
…
addition ‑ overflow_throws
addition ‑ overflow_throws_rev
assignment ‑ assignment_signed<int>
assignment ‑ assignment_signed<long>
assignment ‑ assignment_signed<short>
assignment ‑ assignment_signed<signed_char>
assignment ‑ assignment_unsigned<unsigned_char>
assignment ‑ assignment_unsigned<unsigned_int>
assignment ‑ assignment_unsigned<unsigned_long>
assignment ‑ assignment_unsigned<unsigned_short>
…

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 18, 2024

Gcc Test Results

  160 files   -   1    160 suites   - 1   16m 20s ⏱️ -40s
7 276 tests +190  7 270 ✅ +190  6 💤 ±0  0 ❌ ±0 
7 350 runs  +178  7 344 ✅ +178  6 💤 ±0  0 ❌ ±0 

Results for commit 08bd958. ± Comparison against base commit 9b3fb27.

This pull request removes 3012 and adds 3202 tests. Note that renamed tests count towards both.
addition ‑ wraps
addition ‑ wraps_rev
fields_manual_tests.test_comparison_128_256 ‑ _0
fields_manual_tests.test_comparison_128_256 ‑ _1
fields_manual_tests.test_comparison_128_256 ‑ _10
fields_manual_tests.test_comparison_128_256 ‑ _100
fields_manual_tests.test_comparison_128_256 ‑ _101
fields_manual_tests.test_comparison_128_256 ‑ _102
fields_manual_tests.test_comparison_128_256 ‑ _103
fields_manual_tests.test_comparison_128_256 ‑ _104
…
addition ‑ overflow_throws
addition ‑ overflow_throws_rev
assignment ‑ assignment_signed<int>
assignment ‑ assignment_signed<long>
assignment ‑ assignment_signed<short>
assignment ‑ assignment_signed<signed_char>
assignment ‑ assignment_unsigned<unsigned_char>
assignment ‑ assignment_unsigned<unsigned_int>
assignment ‑ assignment_unsigned<unsigned_long>
assignment ‑ assignment_unsigned<unsigned_short>
…

♻️ This comment has been updated with latest results.

@ioxid ioxid force-pushed the multiprecision-refactoring-step-3 branch 2 times, most recently from 7bf24cf to b8adb34 Compare December 19, 2024 14:45
@ioxid ioxid marked this pull request as ready for review December 19, 2024 15:56
@ioxid ioxid requested a review from martun December 19, 2024 15:56
@ioxid ioxid force-pushed the multiprecision-refactoring-step-3 branch 3 times, most recently from 1b01b72 to b938e9f Compare December 20, 2024 10:52
@ioxid ioxid force-pushed the multiprecision-refactoring-step-3 branch 3 times, most recently from cd75e1c to 6783b80 Compare December 20, 2024 16:17
@ioxid ioxid force-pushed the multiprecision-refactoring-step-3 branch from 6783b80 to 46d55b1 Compare December 21, 2024 16:48
@ioxid ioxid force-pushed the multiprecision-refactoring-step-3 branch from e3bb851 to f713bca Compare December 22, 2024 00:25
@ioxid ioxid force-pushed the multiprecision-refactoring-step-3 branch from f713bca to bdb9324 Compare December 22, 2024 01:06
@ioxid ioxid force-pushed the multiprecision-refactoring-step-3 branch 2 times, most recently from 17732f8 to e0a3887 Compare December 23, 2024 01:46
@ioxid ioxid force-pushed the multiprecision-refactoring-step-3 branch from e0a3887 to 08bd958 Compare December 23, 2024 01:49
@ioxid ioxid added this pull request to the merge queue Dec 23, 2024
Merged via the queue into master with commit 0f6b9b0 Dec 23, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants