Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent traits across modules #40

Open
hgedia opened this issue Nov 4, 2022 · 0 comments
Open

Inconsistent traits across modules #40

hgedia opened this issue Nov 4, 2022 · 0 comments
Assignees
@nkaskov
Labels
bug Something isn't working

Comments

@hgedia
Copy link
Contributor

hgedia commented Nov 4, 2022

We seem to have inconsistent trait definitions across modules. This makes it harder to have a singular concept in documentation.
ex :
https://github.com/NilFoundation/crypto3-pubkey/blob/7fbbf43cbf6fa88ddf0051646321eed2fb6b237e/include/nil/crypto3/detail/type_traits.hpp#L212
and
https://github.com/NilFoundation/crypto3-algebra/blob/311bf0dbdfbb06407599c150c4738d685e10e5f4/include/nil/crypto3/algebra/type_traits.hpp#L79

This issue is to resolve inconsistencies across different modules.

ps: is_curve definition is incorrect as it includes pairing element of g2/gt and perhaps needs a new trait for pairing curves.
@nemothenoone nemothenoone added the bug Something isn't working label Nov 4, 2022
AndreyMlashkin pushed a commit that referenced this issue May 24, 2024
@Zerg1996
Type traits update #40
b7fff15
AndreyMlashkin pushed a commit that referenced this issue Aug 15, 2024
@Zerg1996
Merge pull request #40 from NilFoundation/37-gh-actions-testing
b905308 
Add tests workflow
AndreyMlashkin pushed a commit that referenced this issue Aug 19, 2024
@vo-nil @ETatuzova
38 commitment unchecked (#40)
a912c3a 
* Added unchecked to commitment_scheme #38

* Added unchecked on all functions in commitment scheme #38

* Multiply gate argument result on mask polynomial value #41

* Remove extra parameter #38

* rm extra arguments #38

* Ensure that at lease one constraint is included in module #38

* whitespace cleanup #38

* rm debug print #38

---------

Co-authored-by: e.tatuzova <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nkaskov nkaskov

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nemothenoone @nkaskov @hgedia