Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add launchSettings.json to .gitignore for Files, Nodes, Notes, Reminders and Timelines module #42

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add launchSettings.json to .gitignore for Files, Nodes, Notes, Reminders and Timelines module #42

wants to merge 5 commits into from
+10 −5

Conversation

HunorTotBagi
Copy link
Collaborator

@HunorTotBagi HunorTotBagi commented Jan 7, 2025 •
edited
Loading

Every time when @NikolaDmitrasinovic and I open Visual Studio we are presented with the following:

image

To proceed with new tasks, we have had to manually delete these files repeatedly. To address this, I have made this PR where I include **/launchSettings.json in the .gitignore file.

@HunorTotBagi HunorTotBagi self-assigned this Jan 7, 2025
@HunorTotBagi HunorTotBagi added the enhancement New feature or request label Jan 7, 2025
@HunorTotBagi HunorTotBagi marked this pull request as ready for review January 7, 2025 09:33
@NikolaDmitrasinovic
Copy link
Collaborator

And if you merge this what will happen to the launchSettings.json that we actually need to track?

@HunorTotBagi
Copy link
Collaborator Author

HunorTotBagi commented Jan 7, 2025 •
edited
Loading

Oh yea... **/launchSettings.json will ignore all launchSettings.json in the directory and we don't want to do that for launchSettings.json for Core.Api. Am I correct?

@HunorTotBagi HunorTotBagi added the backend Work performed on the backend solution label Jan 7, 2025
@HunorTotBagi HunorTotBagi changed the title Add **/launchSettings.json to .gitignore Add launchSettings.json to .gitignore for Files, Nodes, Notes, Reminders and Timelines module Jan 8, 2025
@NikolaVetnic
Copy link
Owner

Did you try this, namely adding the following to the .csproj files:

<NoDefaultLaunchSettingsFile>true</NoDefaultLaunchSettingsFile>

@HunorTotBagi
Copy link
Collaborator Author

HunorTotBagi commented Jan 15, 2025 •
edited
Loading

Did you try this, namely adding the following to the .csproj files:

<NoDefaultLaunchSettingsFile>true</NoDefaultLaunchSettingsFile>

It seems that this fixes the problem.

@HunorTotBagi
Copy link
Collaborator Author

HunorTotBagi commented Jan 15, 2025 •
edited
Loading

@NikolaDmitrasinovic Can you please check this new approach weather solves the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikolaDmitrasinovic NikolaDmitrasinovic NikolaDmitrasinovic approved these changes

@NikolaVetnic NikolaVetnic NikolaVetnic approved these changes

Assignees

@HunorTotBagi HunorTotBagi

Labels
backend Work performed on the backend solution enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HunorTotBagi @NikolaDmitrasinovic @NikolaVetnic