Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary lines of code from Service Collection Extensions #39

Merged
merged 4 commits into from
Jan 3, 2025
Merged

Remove unnecessary lines of code from Service Collection Extensions #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a928b4b
fix: remove redundant code
HunorTotBagi Dec 31, 2024
b49e797
chore: remove redundant empty record declaration body
HunorTotBagi Dec 31, 2024
f20d4fa
chore: remove redundant empty record declaration body
HunorTotBagi Dec 31, 2024
032225c
chore: delete unused converter
HunorTotBagi Dec 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions Backend/src/BuildingBlocks/BuildingBlocks.Api/Converters/NodeIdConverter.cs
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions Backend/src/BuildingBlocks/BuildingBlocks.Api/GlobalUsing.cs
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions Backend/src/Modules/Nodes/Nodes.Api/Extensions/ServiceCollectionExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
using BuildingBlocks.Api.Converters;
using Microsoft.Extensions.Configuration;
using Microsoft.Extensions.DependencyInjection;
using Nodes.Application.Extensions;
Expand All @@ -20,8 +19,6 @@ public static IServiceCollection AddNodesModule

private static IServiceCollection AddApiServices(this IServiceCollection services)
{
TypeAdapterConfig.GlobalSettings.Scan(typeof(NodeIdConverter).Assembly);

return services;
}

Expand Down
2 changes: 0 additions & 2 deletions Backend/src/Modules/Nodes/Nodes.Application/Extensions/ServiceCollectionExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ public static IServiceCollection AddApplicationServices(this IServiceCollection
config.AddOpenBehavior(typeof(LoggingBehavior<,>));
});

services.AddValidatorsFromAssembly(Assembly.GetExecutingAssembly());

return services;
}
}
2 changes: 1 addition & 1 deletion Backend/src/Modules/Nodes/Nodes.Domain/Events/NodeCreatedEvent.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@

namespace Nodes.Domain.Events;

public record NodeCreatedEvent(Node Node) : IDomainEvent { }
public record NodeCreatedEvent(Node Node) : IDomainEvent;
2 changes: 1 addition & 1 deletion Backend/src/Modules/Nodes/Nodes.Domain/Events/NodeUpdatedEvent.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@

namespace Nodes.Domain.Events;

public record NodeUpdatedEvent(Node Node) : IDomainEvent { }
public record NodeUpdatedEvent(Node Node) : IDomainEvent;
Loading