Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Decoration.name_expression again because Decoration.name is sufficient #44

Merged
merged 1 commit into from
Aug 31, 2021

Conversation

NiklasRosenstein
Copy link
Owner

Having just the Decoration.name field should be enough if the name can also be an expression.

Code Decorator.name Decorator.args Notes
@property "property" null
@functools.lru_cache(max_size=10) "functools.lru_cache" ["max_size=10"]
@dec['name'] "dec['name']" null since Python 3.9
@(decorators().name)(a, b=c) "(decorators().name)" ["a", "b=c"] since Python 3.9

@NiklasRosenstein NiklasRosenstein added component: docspec The main docspec module, or the docspec JSON specification. type: improvement An improvement to an existing feature. labels Aug 31, 2021
@NiklasRosenstein NiklasRosenstein merged commit a5a2068 into develop Aug 31, 2021
@NiklasRosenstein NiklasRosenstein deleted the remove-decoration-name-expression branch August 31, 2021 13:17
@NiklasRosenstein
Copy link
Owner Author

NiklasRosenstein commented Sep 23, 2021

With #48, it should be

Code Decorator.name Decorator.arglist Notes
@property "property" null
@functools.lru_cache(max_size=10) "functools.lru_cache" ["max_size=10"]
@dec['name'] "dec['name']" null since Python 3.9
@(decorators().name)(a, b=c) "(decorators().name)" ["a", "b=c"] since Python 3.9

(Just renamed Decoration.args to Decoration.arglist)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: docspec The main docspec module, or the docspec JSON specification. type: improvement An improvement to an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant