Formatting fails for HTML custom elements

[mtlynch]

I'm still loving this plugin. Thanks so much for your work on this!

I'm noticing an issue when I try to use it on HTML custom elements that include Go templating.

Works fine

In the following example without any Go template syntax, the prettier-plugin-go template works fine:

<template id="template">
  <script>
    document.getElementById("demo").innerText = "clicked!";
  </script>
  <style>
    #demo {
      font-size: 1.5rem;
    }
  </style>
  <button id="demo">Click me</button>
</template>

Failure to process templated attributes

If I add templated attributes (the nonce={{ .Nonce }} attributes), the plugin seems to get confused

Original

<template id="template">
  <script nonce="{{ .Nonce }}">
    document.getElementById("demo").innerText = "clicked!";
  </script>
  <style nonce="{{ .Nonce }}">
    #demo {
      font-size: 1.5rem;
    }
  </style>
  <button id="demo">Click me</button>
</template>

Formatted

<template id="template"
  >  <script nonce="{{ .Nonce }}">
    document.getElementById("demo").innerText = "clicked!";
  </script>  <style nonce="{{ .Nonce }}">
    #demo {
      font-size: 1.5rem;
    }
  </style>
  <button id="demo">Click me</button>
</template>

And then it mostly stops formatting. So if I add lots of whitespace in the <script> section, the formatter doesn't touch it:

<template id="template"
  >  <script nonce="{{ .Nonce }}">
    document.getElementById("demo").innerText   =        "clicked!";
  </script>  <style nonce="{{ .Nonce }}">
    #demo {
      font-size: 1.5rem;
    }
  </style>
  <button id="demo">Click me</button>
</template>

Workaround

For this use case, the vanilla Prettier formatter formats the code correctly, so I can work around it by using more targeted matchers in my prettierrc to prevent prettier-plugin-go-template from handling these files.

[NiklasPor]

Hey, thanks for reporting the issue 👏

Could you check whether [email protected] resolved this for you?

[mtlynch]

@NiklasPor - wow, fast fix! Yep, I tried installing the beta and confirmed 71dc2e7 works on all of my custom element files.

[NiklasPor]

Great, I'll publish [email protected] as a stable release with the fix then 👍

[NiklasPor]

@all-contributors please add @mtlynch for bug

[allcontributors]

@NiklasPor

I've put up a pull request to add @mtlynch! 🎉