[DEPENDENCY] Update cordova-plugin-add-swift-support to v2.0.1 #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related issue: #153 |
NiklasMerz
requested changes
Apr 2, 2019
I may be misunderstanding, config.xml does not exist in the project. Could you clarify please? |
|
I am sorry. I mean |
byronaltice
force-pushed
the
feature/support-cordova-9
branch
from
9c521ee to
b29b02d
Compare
|
No problem, updated. Please review. Thanks |
byronaltice
force-pushed
the
feature/support-cordova-9
branch
from
b29b02d to
39668ec
Compare
byronaltice
commented
Apr 2, 2019
NiklasMerz
approved these changes
Apr 2, 2019
|
Thanks for this fix. Are we able to merge and create a new release? |
|
I merged it and you can use the master branch. I will try to get a new release out in the next few days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows building in cordova 9. See: akofman/cordova-plugin-add-swift-support#56
How did you test your changes?
Force installed [email protected], and built successfully.