Update development branch to Bevy 0.11-dev #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to Bevy 0.10
…windows Compare paths instead of strings in full_collection example
Use `.track_progress()` in iyes_progress example
…pendencies Remove features for optional dependencies and bump bevy_common_assets
Mention asset unloading in the readme
Allow usage in multiple states
… and adapt examples
…_state Mention adding the default plugins before configuring a loading state
Allow reloading of dynamic asset files
…_criteria Workaround for correct scheduling with non default exit criteria
|
Sorry, I forgot to test with features enabled and one |
The following updates are performed: * update actions/checkout to v3 * update actions/cache to v3
Update actions on GitHub Actions workflows
Basically all of the `actions-rs/*` actions are unmaintained. See <actions-rs/toolchain#216> for more information. Due to their age they generate several warnings in CI runs. To get rid of those warnings the occurrences of `actions-rs/toolchain` are replaced by `dtolnay/rust-toolchain`.
NiklasEi
reviewed
Apr 22, 2023
NiklasEi
reviewed
Apr 22, 2023
…acement Replace unmaintained actions-rs/toolchain action in CI workflows
|
Absolutely, it is added back on. Let me know if there is anything else you want me to check! I also updated it to match the last main commits. |
NiklasEi
approved these changes
May 28, 2023
|
Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps the
bevy_mainbranch with added support for the current development version of bevy, as well as the new commits from themainbranch.The most notable change is the deprecation of
add_systemin favor of a more generaladd_systemsthat takes the schedule as a first parameter bevyengine/bevy#8079. All the examples, tests and source files were revised with this new standard.Base sets are no longer needed so
LoadingStateSetwas removed. However, with bevyengine/bevy#8079 the ability to order sets between schedules was lost. Since the work that was done with the base set had ro be run afterStateTransition, I added them to theUpdatestage, and it seems to work fine. However, if more fine control is needed, a new schedule can be created for them and usingMainScheduleOrderit can be placed betweenStateTransitionandUpdate. However, ordering sets between existing schedules seems to be encouraged.Another change is that
Statenow can't be accessed directly through its tuple field. A new.get()method can be used to get a reference. This works fine in most places, butreset_loading_stateandrun_loading_statewere previously mutating the state through this field, which now is not allowed. The proposed workaround is to remove the internal state resource and add it again with the value we want. I am unsure if this is the best way to do it but couldn't find another that worked.Other than that, all examples and tests were ran and everything seems to be working fine.
Note: While the
bevy_common_assetsdependency has already merged the update tobevy_main, the IyesGames/iyes_progress#23 PR is still in progress, so for now the Cargo.toml links to my fork's branch. This has to be changed once the PR is merged.