Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix semantic versioning issue. #6

Merged
merged 1 commit into from
Feb 1, 2022

Conversation

marcinjzalewski
Copy link
Collaborator

@marcinjzalewski marcinjzalewski commented Feb 1, 2022

Fix semantic versioning issue.
Some tag names do not follow semantic versioning, and does not contain 'v' in the tag name.
We should fix the logic which gets version name from the tag name. Which sometimes does not contain 'v'.

@marcinjzalewski marcinjzalewski requested a review from a team as a code owner February 1, 2022 12:29
@codecov
Copy link

codecov bot commented Feb 1, 2022

Codecov Report

Merging #6 (c2b5f42) into master (f33e500) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #6   +/-   ##
=======================================
  Coverage   81.21%   81.21%           
=======================================
  Files          26       26           
  Lines         708      708           
=======================================
  Hits          575      575           
  Misses        133      133           
Impacted Files Coverage Δ
pterradactyl/terraform/terraform.py 76.35% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f33e500...c2b5f42. Read the comment docs.

@marcinjzalewski marcinjzalewski force-pushed the fix-semantic-versioning-issue branch from 7eb58b0 to 4633811 Compare February 1, 2022 14:27
@marcinjzalewski marcinjzalewski force-pushed the fix-semantic-versioning-issue branch from 4633811 to c2b5f42 Compare February 1, 2022 14:36
Copy link
Contributor

@abdulhuq811 abdulhuq811 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary: Remove v from version

@marcinjzalewski marcinjzalewski merged commit 3d34f80 into master Feb 1, 2022
@marcinjzalewski marcinjzalewski deleted the fix-semantic-versioning-issue branch February 1, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants