Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR does two things:
gimme-aws-creds --configure
from settingdevice_token
to an invalid value.Related Issue
#407
Motivation and Context
I was getting double-MFAs. My config file contained
device_token=
.After some pondering, I decided the default value for a feature is likely not intended to break said feature.
How Has This Been Tested?
gimme-aws-creds --configure && gimme-aws-creds && gimme-aws-creds
without my changes. 2 MFAs on second gimme-creds.gimme-aws-creds && gimme-aws-creds
without my changes. 2 MFAs on second gimme-creds.gimme-aws-creds --configure && sed -i'.bak' "s/device_token =.*//" ~/.okta_aws_login_config && gimme-aws-creds && gimme-aws-creds
without my changes. 1 MFA on second gimme-creds.gimme-aws-creds --configure && gimme-aws-creds && gimme-aws-creds
with my changes. 1 MFA on second gimme-creds.gimme-aws-creds && gimme-aws-creds
with my changes. 1 MFA on second gimme-creds.Types of changes
Checklist: