Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This corrects an issue with the validation of the org url and app url… #375

Merged
merged 1 commit into from
Dec 21, 2022
Merged

This corrects an issue with the validation of the org url and app url… #375

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions gimme_aws_creds/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ def _get_org_url_entry(self, default_entry):
"okta-emea.com",
]

if url_parse_results.scheme == "https" and okta_org_url in allowlist:
if url_parse_results.scheme == "https" and any(urlelement in url_parse_results.hostname for urlelement in allowlist):
okta_org_url_valid = True
else:
ui.default.error(
Expand Down Expand Up @@ -366,7 +366,7 @@ def _get_appurl_entry(self, default_entry):
"okta-emea.com",
]

if url_parse_results.scheme == "https" and app_url in allowlist:
if url_parse_results.scheme == "https" and any(urlelement in url_parse_results.hostname for urlelement in allowlist):
okta_org_url_valid = True
else:
ui.default.warning(
Expand Down