Only mfa as default #371
Merged
Only mfa as default #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit pins ctap-keyring-device to 1.0.6, before I'm release a new v2.0.0 that requires fido2 v1.0.0, which has numerous breaking changes that would affect gimme-aws-creds. Once pinned, I'll create a new tag from: dany74q/ctap-keyring-device#9 Then I'll create a separate PR here which bumps the pinned versions of fido2 and ctap-keyring-device, along w/ fixing all breaking changes.
|
The changes look good - thanks! |
6 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if there's only 1 mfa available use it directly by default.
Description
using the only factor
Related Issue
Motivation and Context
avoid choosing the only option available
How Has This Been Tested?
locally
Screenshots (if appropriate):
Types of changes
Checklist: