Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return correct exit code on interrupt #245

Merged
merged 1 commit into from
Oct 13, 2020
Merged

fix: return correct exit code on interrupt #245

merged 1 commit into from
Oct 13, 2020

Conversation

kirilyuro
Copy link

@kirilyuro kirilyuro commented Sep 6, 2020

Description

Changed entry script to return status code 130, instead of 0, on KeyboardInterrupt.

Related Issue

#244

Motivation and Context

When used in other scripts that rely on gimme-aws-creds, this will enable to distinguish between the credentials being acquired successfully vs gimme-aws-creds being interrupted without actually acquiring the credentials.

How Has This Been Tested?

Made this change locally in my /usr/local/bin/gimme-aws-creds (macOS), saw that this now returns the correct status when interrupted.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Sector95 Sector95 merged commit 35655b9 into Nike-Inc:master Oct 13, 2020
@kirilyuro kirilyuro deleted the script-exit-code-fix branch October 17, 2020 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants