Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed default swift version #39

Merged
merged 1 commit into from
May 2, 2019
Merged

Fixed default swift version #39

merged 1 commit into from
May 2, 2019

Conversation

gtrop1
Copy link

@gtrop1 gtrop1 commented May 2, 2019

No description provided.

@gtrop1 gtrop1 added the swift label May 2, 2019
@gtrop1 gtrop1 added this to the 3.1.1 milestone May 2, 2019
Copy link
Member

@cnoon cnoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small comments back.

---

## [3.1.1](https://github.com/Nike-Inc/Elevate/releases/tag/3.1.1)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the release section here linking the milestone.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also missing the release at the top.

Addressed issue where Swift version was incorrectly set to 5.0 when it should have been 4.2.
Copy link
Member

@cnoon cnoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@gtrop1 gtrop1 merged commit 13d37c4 into hotfix May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants