Fixed tests and documentation for removed properties.

NightTsarina · Mar 14, 2022 · f69e8ed · f69e8ed
1 parent bfe9a0b
commit f69e8ed
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 62 deletions.
diff --git a/docs/api/options.rst b/docs/api/options.rst
@@ -504,57 +504,6 @@ Options objects
         | *Type:* ``bool``
         | *Default:* ``False``
 
-    .. py:attribute:: soft_rate_limit
-
-        .. IMPORTANT::
-
-            NOT SUPPORTED ANYMORE -- this option is no longer used
-
-        Puts are delayed 0-1 ms when any level has a compaction score that exceeds
-        soft_rate_limit. This is ignored when == 0.0.
-        CONSTRAINT: soft_rate_limit <= hard_rate_limit. If this constraint does not
-        hold, RocksDB will set soft_rate_limit = hard_rate_limit.
-        A value of ``0`` means disabled.
-
-        | *Type:* ``float``
-        | *Default:* ``0``
-
-    .. py:attribute:: hard_rate_limit
-
-        .. IMPORTANT::
-
-            NOT SUPPORTED ANYMORE -- this option is no longer used
-
-        Puts are delayed 1ms at a time when any level has a compaction score that
-        exceeds hard_rate_limit. This is ignored when <= 1.0.
-        A value fo ``0`` means disabled.
-
-        | *Type:* ``float``
-        | *Default:* ``0``
-
-    .. py:attribute:: rate_limit_delay_max_milliseconds
-
-        .. IMPORTANT::
-
-            NOT SUPPORTED ANYMORE -- this option is no longer used
-
-        Max time a put will be stalled when hard_rate_limit is enforced. If 0, then
-        there is no limit.
-
-        | *Type:* ``int``
-        | *Default:* ``1000``
-
-    .. py:attribute:: purge_redundant_kvs_while_flush
-
-        .. IMPORTANT::
-
-            NOT SUPPORTED ANYMORE -- this option is no longer used
-
-        Purge duplicate/deleted keys when a memtable is flushed to storage.
-
-        | *Type:* ``bool``
-        | *Default:* ``True``
-
 
 
 .. py:class:: rocksdb.Options
@@ -819,14 +768,6 @@ Options objects
         | *Type:* ``bool``
         | *Default:* ``True``
 
-    .. py:attribute:: skip_log_error_on_recovery
-
-        Skip log corruption error on recovery
-        (If client is ok with losing most recent changes)
-
-        | *Type:* ``bool``
-        | *Default:* ``False``
-
     .. py:attribute:: stats_dump_period_sec
 
         If not zero, dump rocksdb.stats to LOG every stats_dump_period_sec

diff --git a/rocksdb/options.pxd b/rocksdb/options.pxd
@@ -134,7 +134,6 @@ cdef extern from "rocksdb/options.h" namespace "rocksdb":
         cpp_bool use_direct_io_for_flush_and_compaction
         cpp_bool allow_fallocate
         cpp_bool is_fd_close_on_exec
-        cpp_bool skip_log_error_on_recovery
         unsigned int stats_dump_period_sec
         unsigned int stats_persist_period_sec
         cpp_bool persist_stats_to_disk

diff --git a/rocksdb/tests/test_options.py b/rocksdb/tests/test_options.py
@@ -1,7 +1,9 @@
-import unittest
 import sys
+import unittest
+
 import rocksdb
 
+
 class TestFilterPolicy(rocksdb.interfaces.FilterPolicy):
     def create_filter(self, keys):
         return b'nix'
@@ -230,7 +232,6 @@ def test_rocksdb_options(self):
                 ('use_direct_io_for_flush_and_compaction', False, True),
                 ('allow_fallocate', True, False),
                 ('is_fd_close_on_exec', True, False),
-                ('skip_log_error_on_recovery', False, True),
                 ('stats_dump_period_sec', 600, 3600),
                 ('stats_persist_period_sec', 600, 3600),
                 ('persist_stats_to_disk', False, True),