Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed kNN for kNNBasic on issue #131 #138

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fixed kNN for kNNBasic on issue #131 #138

wants to merge 3 commits into from

Conversation

ODemidenko
Copy link
Contributor

currently I introduced all the changes only to one kNN algo. If you ok with this implementation - I immediately proceed with the others

  • Move "Compute similarity" from AlgoBase into SymmetricAlg (as it belongs to kNN only)
  • implement common logic for fixed kNN
  • inject new logic into kNNBasic, as optional behaviour
  • test new behaviour vs teacher examples from Coursera course
  • inject new logic into kNNWithMeans, as optional behaviour
  • inject new logic into kNNBaseline, as optional behaviour

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ODemidenko