-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move UI State Management variables from ClockPageViewModel to ClockPageViewModelState object #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d function declarations into there. Some small cleanup.
…y ClockPage composable preview again!
…State class. Create unit tests.
…odelState. Write unit tests for text changes.
…st, write instrumented test for count down
NicksPatties
commented
Aug 8, 2022
app/src/main/java/com/nickspatties/timeclock/ui/components/EditTimerTextField.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/nickspatties/timeclock/ui/components/TaskTextField.kt
Show resolved
Hide resolved
modifier = Modifier.testTag("DropdownMenuItem_${label}"), | ||
onClick = { | ||
if (viewModelState.countDownTimerEnabled) { | ||
focusManager.moveFocus(FocusDirection.Next) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something for later, but can this logic be moved into the ClockPageViewModelState class, or at least the currently focused object.
This was referenced Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Quickly testing functionality of elements in the ClockPage is a hassle. Creating a test version of a ClockPageViewModel was annoying for a few reasons.
To that end, I created the ClockPageViewModelState class, which serves as a layer between the ClockPageViewModel's event data and user preferences, and the UI components. Some benefits:
Changes
Lots... but the big ones are:
ClockPageViewModelState
class, and migrating some properties fromClockPageViewModel
to there.ClockPage
component. Some import and code cleanup.Related issue
None. This was just some code cleanliness stuff that was nagging me.
Testing