Don't count past zero when counting down #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicksPatties
deleted the
12-bug-alarm-doesnt-fire-when-counting-down-for-a-long-time
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
currCountDownSecondsto 0 when I count, and I'm currently past the event's scheduled end timeThis fixes part of the bug with the related issue. Since the complete fix requires a new feature to guide the user to change their app's battery settings, the rest of the fix will occur when that feature is fleshed out and completed. For now, this removes the UI jank caused by
currCountDownSecondsbeing a negative number.Related issue
#12
Testing