Skip to content

Commit

Permalink
Fix JS build on Windows
Browse files Browse the repository at this point in the history
Summary: Node made a breaking change in a security release for 18/20 where `spawn()` no longer loads `.cmd` files by default. nodejs/node#52554. Execute command in shell.

Differential Revision: D56230965
  • Loading branch information
NickGerleman authored and facebook-github-bot committed Apr 17, 2024
1 parent cd4a1b8 commit 90af442
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions javascript/just.config.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,7 @@ function emcmakeGenerateTask() {

return spawn(emcmakeBin, args, {
stdio: logger.enableVerbose ? 'inherit' : 'ignore',
shell: true,
});
};
}
Expand Down

0 comments on commit 90af442

Please sign in to comment.