Add event for RenderUnit.Updated

Summary: Adds an event for `RenderUnit.Updated`. I will use this for tooling in IG> Reviewed By: adityasharat Differential Revision: D45228498 fbshipit-source-id: 13e524bca24f0b9a9e38015d749013b4b87d552e
NickGerleman · Apr 24, 2023 · c6e8566 · c6e8566
1 parent 2b70179
commit c6e8566
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 8 deletions.
diff --git a/litho-rendercore/src/main/java/com/facebook/rendercore/MountState.java b/litho-rendercore/src/main/java/com/facebook/rendercore/MountState.java
@@ -833,6 +833,8 @@ private void unmountItemRecursively(final long id) {
         attributes -> {
           attributes.put(RenderUnitId, id);
           attributes.put(Description, unit.getDescription());
+          attributes.put(Bounds, node.getBounds());
+          attributes.put(RootHostHashCode, mRootHost.hashCode());
         },
         scope -> {
           if (isTracing) {
@@ -1084,14 +1086,27 @@ private void updateMountItemIfNeeded(RenderTreeNode renderTreeNode, MountItem cu
         mTracer.beginSection("UpdateItem: " + renderUnit.getDescription());
       }
 
-      renderUnit.updateBinders(
-          mContext,
-          content,
-          currentRenderUnit,
-          currentLayoutData,
-          newLayoutData,
-          mountDelegate,
-          currentMountItem.isBound());
+      trace(
+          DebugEvent.RenderUnitUpdated,
+          String.valueOf(mRenderTree.getRenderStateId()),
+          attributes -> {
+            attributes.put(RenderUnitId, renderTreeNode.getRenderUnit().getId());
+            attributes.put(Description, renderTreeNode.getRenderUnit().getDescription());
+            attributes.put(Bounds, renderTreeNode.getBounds());
+            attributes.put(RootHostHashCode, mRootHost.hashCode());
+          },
+          scope -> {
+            renderUnit.updateBinders(
+                mContext,
+                content,
+                currentRenderUnit,
+                currentLayoutData,
+                newLayoutData,
+                mountDelegate,
+                currentMountItem.isBound());
+
+            return Unit.INSTANCE;
+          });
     }
 
     currentMountItem.setIsBound(true);

diff --git a/litho-rendercore/src/main/java/com/facebook/rendercore/debug/DebugEvents.kt b/litho-rendercore/src/main/java/com/facebook/rendercore/debug/DebugEvents.kt
@@ -38,6 +38,7 @@ sealed class DebugEvent(
     const val MountItemMount = "RenderCore.MountItem.Mount"
     const val RenderUnitMounted = "RenderCore.RenderUnit.Mounted"
     const val RenderUnitUnmounted = "RenderCore.RenderUnit.Unmounted"
+    const val RenderUnitUpdated = "RenderCore.RenderUnit.Updated"
   }
 
   /** Returns the value of attribute with [name]. */