chore(refactor): handle 0-length args in highest_precedence_shape()

moving towards ibis-project#8666
NickCrews · Jun 7, 2024 · 6a2f71d · 6a2f71d
1 parent 1055ce3
commit 6a2f71d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/ibis/expr/operations/arrays.py b/ibis/expr/operations/arrays.py
@@ -20,9 +20,7 @@ class Array(Value):
 
     exprs: VarTuple[Value]
 
-    @attribute
-    def shape(self):
-        return rlz.highest_precedence_shape(self.exprs)
+    shape = rlz.shape_like("exprs")
 
     @attribute
     def dtype(self):

diff --git a/ibis/expr/rules.py b/ibis/expr/rules.py
@@ -5,6 +5,7 @@
 
 from public import public
 
+import ibis.expr.datashape as ds
 import ibis.expr.datatypes as dt
 import ibis.expr.operations as ops
 from ibis import util
@@ -16,6 +17,9 @@
 
 @public
 def highest_precedence_shape(nodes):
+    nodes = tuple(nodes)
+    if len(nodes) == 0:
+        return ds.scalar
     return max(node.shape for node in nodes)