Merge pull request TheWidlarzGroup#1720 from nmarisi/fix-NSInternalIn…

…consistencyException Removing the call to observeValueForKeyPath:ofObject:change:context: …
NickAVolpe · Sep 8, 2019 · f66ca32 · f66ca32
2 parents 0a2f7bd + 9272678
commit f66ca32
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,8 @@
 ## Changelog
 
+### Version 5.0.2
+* Fix crash when RCTVideo's superclass doesn't observe the keyPath 'frame' (iOS) [#1720](https://github.com/react-native-community/react-native-video/pull/1720)
+
 ### Version 5.0.1
 * Fix AndroidX Support bad merge
 

diff --git a/ios/Video/RCTVideo.m b/ios/Video/RCTVideo.m
@@ -712,8 +712,6 @@ - (void)observeValueForKeyPath:(NSString *)keyPath ofObject:(id)object change:(N
 
         return;
       }
-  } else if ([super respondsToSelector:@selector(observeValueForKeyPath:ofObject:change:context:)]) {
-    [super observeValueForKeyPath:keyPath ofObject:object change:change context:context];
   }
 }
-Original file line number
+Diff line change
@@ Expand Up @@
             return;
           }
-      } else if ([super respondsToSelector:@selector(observeValueForKeyPath:ofObject:change:context:)]) {
-        [super observeValueForKeyPath:keyPath ofObject:object change:change context:context];
       }
     }
@@ Expand Down @@