Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: ../.. instead of src #296

Merged
merged 2 commits into from
Jan 23, 2024
Merged

refactor: ../.. instead of src #296

merged 2 commits into from
Jan 23, 2024

Conversation

CalicoNino
Copy link
Contributor

@CalicoNino CalicoNino commented Jan 23, 2024 •
edited by coderabbitai bot
Loading

src/.. gave me the following error when deploying:

TypeError: The specifier “src/protojs/nibiru/perp/v2/tx” was a bare specifier, but was not remapped to anything. Relative module specifiers must start with “./”, “../” or “/”.

Locally changed all src/protojs to ../../protojs and it was fixed.

Summary by CodeRabbit

  • Refactor
    • Improved path resolution in the build process for better module compatibility.

@CalicoNino CalicoNino self-assigned this Jan 23, 2024
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 23, 2024 •
edited
Loading

Warning

Rate Limit Exceeded

@elshenak has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 17 minutes and 8 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between 89c08ab and 9c14ebe.

Walkthrough

The modification to the build.sh script addresses an issue with module path resolution in the built distribution. The script's sed command has been updated to correct the path references in require statements, changing from a src-based path to a relative path that correctly points to the necessary TypeScript and JavaScript files within the dist directory.

Changes

File(s) Change Summary
scripts/build.sh Updated sed command to fix module path resolution from @/ to ../../.

Poem

🐇 In the script's shell, paths were astray,
🛠️ With a sed tweak, we found our way.
📂 From @/ to dots, now all align,
🎉 'Tis a code hop to build so fine!

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

coderabbitai[bot]
coderabbitai bot reviewed Jan 23, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between caad35d and 89c08ab.
Files selected for processing (1)
  • scripts/build.sh (1 hunks)
Files skipped from review due to trivial changes (1)
  • scripts/build.sh

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 23, 2024 •
edited
Loading

Lines Statements Branches Functions
Coverage: 96%
 96.81% (6018/6216) 98.26% (679/691) 84.93% (186/219)

ruslan-sh-r
ruslan-sh-r requested changes Jan 23, 2024
View reviewed changes
scripts/build.sh Outdated Show resolved Hide resolved
@CalicoNino CalicoNino enabled auto-merge (squash) January 23, 2024 17:06
@CalicoNino CalicoNino merged commit e51c214 into develop Jan 23, 2024
1 check passed
@CalicoNino CalicoNino deleted the refactor/path-resolve branch January 23, 2024 17:07
cgilbe27 added a commit that referenced this pull request Jan 23, 2024
@cgilbe27
refactor: ../.. instead of src (#296)
7cfdf7a 
refactor: ../.. instead of src (#296)
nibibot pushed a commit that referenced this pull request Jan 23, 2024
@semantic-release-bot
chore(release): 2.0.0
ee18f23 
## [2.0.0](v1.0.2...v2.0.0) (2024-01-23)

### Code Refactors

* ../.. instead of src ([#296](#296)) ([7cfdf7a](7cfdf7a))
* ../.. instead of src ([#296](#296)) ([e51c214](e51c214))

 [skip ci]
@nibibot
Copy link

nibibot commented Jan 23, 2024

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@ruslan-sh-r ruslan-sh-r ruslan-sh-r approved these changes

@cgilbe27 cgilbe27 cgilbe27 approved these changes

Assignees

@CalicoNino CalicoNino

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CalicoNino @nibibot @ruslan-sh-r @cgilbe27