Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove all stringer for proto types #1874

Merged
merged 10 commits into from
May 20, 2024
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- [#1864](https://github.com/NibiruChain/nibiru/pull/1864) - fix(ica): add ICA controller stack
- [#1872](https://github.com/NibiruChain/nibiru/pull/1872) - chore(math): use cosmossdk.io/math to replace sdk types

* [#1874](https://github.com/NibiruChain/nibiru/pull/1874) - chore(proto): remove the proto stringer as per Cosmos SDK migration guidelines
matthiasmatt marked this conversation as resolved.
Show resolved Hide resolved

#### Nibiru EVM

- [#1837](https://github.com/NibiruChain/nibiru/pull/1837) - feat(eth): protos, eth types, and evm module types
Expand Down
26 changes: 13 additions & 13 deletions eth/account.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion proto/eth/types/v1/account.proto
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ option go_package = "github.com/NibiruChain/nibiru/eth";
// authtypes.BaseAccount type. It is compatible with the auth AccountKeeper.
message EthAccount {
option (gogoproto.goproto_getters) = false;
option (gogoproto.goproto_stringer) = false;
option (gogoproto.equal) = false;

option (cosmos_proto.implements_interface) = "github.com/cosmos/cosmos-sdk/x/auth/types.cosmos.auth.v1beta1.AccountI";
Expand Down
4 changes: 0 additions & 4 deletions proto/nibiru/oracle/v1/oracle.proto
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ option go_package = "github.com/NibiruChain/nibiru/x/oracle/types";
// Params defines the module parameters for the x/oracle module.
message Params {
option (gogoproto.equal) = true;
option (gogoproto.goproto_stringer) = false;

// VotePeriod defines the number of blocks during which voting takes place.
uint64 vote_period = 1 [ (gogoproto.moretags) = "yaml:\"vote_period\"" ];
Expand Down Expand Up @@ -91,7 +90,6 @@ message Params {
message AggregateExchangeRatePrevote {
option (gogoproto.equal) = false;
option (gogoproto.goproto_getters) = false;
option (gogoproto.goproto_stringer) = false;

string hash = 1 [ (gogoproto.moretags) = "yaml:\"hash\"" ];
string voter = 2 [ (gogoproto.moretags) = "yaml:\"voter\"" ];
Expand All @@ -103,7 +101,6 @@ message AggregateExchangeRatePrevote {
message AggregateExchangeRateVote {
option (gogoproto.equal) = false;
option (gogoproto.goproto_getters) = false;
option (gogoproto.goproto_stringer) = false;

repeated ExchangeRateTuple exchange_rate_tuples = 1 [
(gogoproto.moretags) = "yaml:\"exchange_rate_tuples\"",
Expand All @@ -118,7 +115,6 @@ message AggregateExchangeRateVote {
message ExchangeRateTuple {
option (gogoproto.equal) = false;
option (gogoproto.goproto_getters) = false;
option (gogoproto.goproto_stringer) = false;

string pair = 1 [
(gogoproto.moretags) = "yaml:\"pair\"",
Expand Down
262 changes: 0 additions & 262 deletions proto/nibiru/perp/v2/event.proto

This file was deleted.

Loading
Loading