-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create settle position function #1632
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1632 +/- ##
==========================================
- Coverage 74.52% 74.32% -0.21%
==========================================
Files 177 177
Lines 14652 14814 +162
==========================================
+ Hits 10919 11010 +91
- Misses 3112 3176 +64
- Partials 621 628 +7
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I am a bit curious about how we can handle the fact that there's a variable part that could be unexpectedly large for the funding payments.
Also, when we close one market, how are the conditions for the next market selected?
We have this issue for settlement and also normal behavior of the market. I think the clamp is helping us a lot in this since closing a market might have a lot to do with index/mark price divergence |
Description
Purpose
Why is this PR important?