Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for bq cervantes and fnac touch devices #17

Merged
merged 1 commit into from
Oct 18, 2018

Conversation

pazos
Copy link
Contributor

@pazos pazos commented Oct 11, 2018

add support for bq cervantes and fnac touchlight devices (a list of devices on https://blog.bq.com/es/bq-ereaders-developers-program/)

@NiLuJe
Copy link
Owner

NiLuJe commented Oct 13, 2018

That's a great start ;). With a bit of luck, there's no weird quirks to take into account, and it's basically all that's needed ;).

Speaking of: there's a bunch more ifdeffery involved in fbink_internal.h for the mxcfb header selection, and in fbink_cmd.c for the help message ;).

@NiLuJe
Copy link
Owner

NiLuJe commented Oct 13, 2018

And, of course, a true no-op in fbink_init to silence that Kobo warning ;).

EDIT: Well, identify_device in fbink_device_id.c, actually ;).

@pazos
Copy link
Contributor Author

pazos commented Oct 13, 2018

@NiLuJe thanks for the hints.

I've added device detection based on HWCONFIG pcb ids and added a deviceQuirks for new cervantes3/cervantes4 devices (based on KoboMk7 update). Everything works as expected on my end 😄

Note: refresh for old devices works ok on newer ones as well.

TODO: don't build button_scan when targetting cervantes devices :P

./fbink "hello" -m -S 12 -y 5   
[FBInk] Clock tick frequency appears to be 100 Hz
[FBInk] Variable fb info: 1072x1448, 16bpp @ rotation: 3 (Counter Clockwise, 270°)
[FBInk] Fontsize set to 96x96 (IBM base glyph size: 8x8)
[FBInk] Line length: 11 cols, Page size: 15 rows
[FBInk] Vertical fit isn't perfect, shifting rows down by 4 pixels
[FBInk] Fixed fb info: ID is "mxc_epdc_fb", length of fb mem: 6782976 bytes & line length: 2176 bytes
[FBInk] Pen colors set to #000000 for the foreground and #FFFFFF for the background
Printing string 'hello' @ column 0 + 0px, row 5 + 0px (overlay: false, backgroundless: false, inverted: false, flashing: false, centered: true, left padded: false, clear screen: false, font: 0, font scaling: x12)

@pazos pazos changed the title [WIP]: add support for bq cervantes and fnac touch devices add support for bq cervantes and fnac touch devices Oct 13, 2018
@NiLuJe
Copy link
Owner

NiLuJe commented Oct 14, 2018

👍

Yeah, currently, Mk7 Kobo devices also still handle the legacy ioctls ;).

@pazos
Copy link
Contributor Author

pazos commented Oct 14, 2018

It seems than button_scan binary is built even for kindle. So its out of the scope for this PR. Please feel free to review 👍

@NiLuJe
Copy link
Owner

NiLuJe commented Oct 15, 2018

Yep, it just returns ENOSYS on unsupported devices with yet another bit of iffdeffery ;).

Besides that, I kind of preferred the typedef in the header and not inside the body of the function ;).

That's the only thing that really jumped out after a quick look see, I'll take another look tomorrow, thanks!

@NiLuJe
Copy link
Owner

NiLuJe commented Oct 18, 2018

Merging, thanks!

(FYI: We don't get notifications on a force push, so don't hesitate to ping when you do that ;)).

@NiLuJe NiLuJe merged commit ff2fc4c into NiLuJe:master Oct 18, 2018
NiLuJe added a commit that referenced this pull request Oct 18, 2018
@pazos pazos deleted the cervantes_support branch October 19, 2018 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants