Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quotes pagination #54

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Quotes pagination #54

merged 1 commit into from
Jan 6, 2025

Conversation

NiJeTi
Copy link
Owner

@NiJeTi NiJeTi commented Jan 4, 2025

Closes #43

@NiJeTi NiJeTi force-pushed the feature/quotes-pagination branch 2 times, most recently from 416f82d to 696b0e7 Compare January 6, 2025 16:07
@coveralls
Copy link
Collaborator

coveralls commented Jan 6, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12636206032

Details

  • 74 of 123 (60.16%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-3.7%) to 85.089%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/pkg/discordUtils/commands.go 18 23 78.26%
internal/handlers/quote/handler.go 0 44 0.0%
Files with Coverage Reduction New Missed Lines %
internal/handlers/quote/handler.go 1 0.0%
Totals Coverage Status
Change from base Build 12605188046: -3.7%
Covered Lines: 428
Relevant Lines: 503
💛 - Coveralls

@NiJeTi NiJeTi force-pushed the feature/quotes-pagination branch from 696b0e7 to 5687789 Compare January 6, 2025 16:23
@NiJeTi NiJeTi marked this pull request as ready for review January 6, 2025 16:26
@NiJeTi NiJeTi merged commit 6cff426 into main Jan 6, 2025
5 checks passed
@NiJeTi NiJeTi deleted the feature/quotes-pagination branch January 6, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Limit quotes output
2 participants
@NiJeTi @coveralls