Hint functionality for user password #18

Bhawna-Ad · 2021-06-23T06:53:09Z

Description

Made the following changes :

Added hint textfield

Passed the hint string to ChooseMasterPswrdViewModel

Working on #3

Type of change

New feature

Code quality checklist

Just put an x in the [] where applicable.

[] I ran gradlew lint and found no new error related to my code in the report.
[] I ran Analyze>Inspect Code and found no new error related to my code.
[] I have verified my changes on an emulator/ real device.

Ni3verma · 2021-06-23T07:11:01Z

Hi @Bhawna-Ad , as this is a UI change can you also update PR with the screenshot of your change?

and I see that your fork dont have latest master changes.. so this is what you have to do:
checkout your local master > set upstream master > pull my master(upstream) changes in your master -- now your master is same as mine
now merge your local master in this new branch > resolve conflicts (if any) and push
Let me know if you need any kind of help :)

Bhawna-Ad · 2021-06-23T07:35:12Z

Sure, I will do the needful. Do I have to upload the screenshot here in this thread only? And also it is showing "some checks were not successful" so how do I resolve this?

…ature/add-hint

Ni3verma · 2021-06-23T07:41:45Z

Not in the thread, you can edit your PR by clicking on this icon and paste the image

and for CICD failure : for now ignore it, I think it could be because you don't have latest master changes merged in this branch. once you merge and push, it will again run automatically. If it fails again I will check

Bhawna-Ad · 2021-06-23T07:58:26Z

Alright, thanks! So after merging do I need to create another draft pull request?😅

Ni3verma · 2021-06-23T08:10:43Z

no you only have to commit and push. It will automatically reflect here

Bhawna-Ad · 2021-06-23T08:37:07Z

I have updated the Pull request with the image of the changes in the UI

Ni3verma

Reviewed first set of changes.
few minor changes to do.. functionality wise everything is working as it should be 💯

app/src/main/res/layout/choose_master_pswrd_fragment.xml

Ni3verma · 2021-06-23T12:42:07Z

Hey there !
I have reviewed the code, excellent work!
and you can ignore the failing check, there is some issue with github hosted runners which you can track here.

Bhawna-Ad · 2021-06-24T05:35:07Z

I am glad to hear that! I have made the required changes now should I commit and push them to this PR only?

Ni3verma · 2021-06-24T05:55:35Z

yes once you make a PR, you only have to push to that branch and it will automatically reflect here

Bhawna-Ad · 2021-06-24T06:24:19Z

The PR is updated. Please suggest if there are any other changes to be made and how to proceed further.

Ni3verma

If done by mistake then you can undo it. or let me know if there is a reason behind it.

.idea/gradle.xml

Ni3verma · 2021-06-24T09:42:35Z

Next instead of validation, you can pick up to show this hint in login screen. Here I want you to be creative on how to show hint. always show it? show it on click of button? or show it on click of a text "show hint"? whatever looks good. I am more inclined toward showing it on click of a text.
and have you worked on Room library?

Bhawna-Ad · 2021-06-24T09:56:21Z

Well yes I like the idea of showing hint on clicking the text. I would like to implement that.
I haven't worked on Room library but I can surely learn about it and then work on it.

Ni3verma · 2021-06-24T10:01:00Z

yeah Room is very famous and also very easy to learn. not much will be required as part of this issue.
first work on the UI, layout > handling click > showing the text (for now you will not be getting the hint in login view model so you can hardcode it)

next I will tell you how to encrypt the hint before adding in db as you are not doing it. and then later with room how to decrypt and get that hint in login view model

Bhawna-Ad · 2021-06-24T10:09:16Z

Okay! I will update you once I am done with that.

…ature/add-hint

Ni3verma · 2021-06-24T10:25:11Z

@Bhawna-Ad
also fetch latest changes from my master to your master and merge in this branch... after this no code check will fail and I can run pipeline on this code.

Bhawna-Ad · 2021-06-24T10:42:55Z

Yes I have updated my branch and now it is even with your master branch

app/src/main/java/com/andryoga/safebox/data/db/secureDao/UserDetailsDaoSecure.kt

…eature/add-hint � Conflicts: � app/src/main/java/com/andryoga/safebox/ui/common/Utils.kt

Ni3verma

call dao.getHint method

app/src/main/java/com/andryoga/safebox/data/db/secureDao/UserDetailsDaoSecure.kt

Ni3verma

Make Hint optional everywhere

app/src/main/java/com/andryoga/safebox/data/db/dao/UserDetailsDao.kt

app/src/main/java/com/andryoga/safebox/data/db/secureDao/UserDetailsDaoSecure.kt

app/src/main/java/com/andryoga/safebox/data/repository/UserDetailsRepositoryImpl.kt

app/src/main/java/com/andryoga/safebox/data/repository/interfaces/UserDetailsRepository.kt

Ni3verma

!! operator will throw Null pointer exception if hint is null

app/src/main/java/com/andryoga/safebox/data/db/secureDao/UserDetailsDaoSecure.kt

app/src/main/java/com/andryoga/safebox/data/repository/UserDetailsRepositoryImpl.kt

Ni3verma

Great !

…eature/add-hint

…eature/add-hint � Conflicts: � app/src/main/java/com/andryoga/safebox/ui/common/Utils.kt

…eature/add-hint

Ni3verma

excellent work with implementing LCS.
but functionality wise there are many issues, see my comments

app/src/main/java/com/andryoga/safebox/ui/view/chooseMasterPswrd/ChooseMasterPswrdFragment.kt

app/src/main/res/layout/choose_master_pswrd_fragment.xml

Ni3verma

Hint is overriding pswrd validation rules !

app/src/main/java/com/andryoga/safebox/ui/view/chooseMasterPswrd/ChooseMasterPswrdFragment.kt

Signed-off-by: Nitin Verma <[email protected]>

Ni3verma · 2021-07-29T15:20:48Z

Awesome work again.. Thanks for your contribution :)

Bhawna-Ad · 2021-07-29T15:39:33Z

It was an awesome experience working on this project.🙌

Bhawna-Ad added 2 commits June 23, 2021 12:03

Added hint textfield

d522965

Added hint textfield

7b87626

Merge branch 'master' of https://github.com/Ni3verma/Safe-Box into fe…

e91deed

…ature/add-hint

Ni3verma assigned Bhawna-Ad Jun 23, 2021

Ni3verma self-requested a review June 23, 2021 07:42

Ni3verma added the enhancement Enhancing existing functionality label Jun 23, 2021

Ni3verma marked this pull request as ready for review June 23, 2021 12:12

Ni3verma changed the title ~~Feature/add hint~~ Hint functionality for user password Jun 23, 2021

Ni3verma requested changes Jun 23, 2021

View reviewed changes

app/src/main/res/layout/choose_master_pswrd_fragment.xml Outdated Show resolved Hide resolved

app/src/main/res/layout/choose_master_pswrd_fragment.xml Show resolved Hide resolved

app/src/main/res/layout/choose_master_pswrd_fragment.xml Outdated Show resolved Hide resolved

Ni3verma marked this pull request as draft June 23, 2021 12:37

Ni3verma linked an issue Jun 23, 2021 that may be closed by this pull request

Add Hint functionality for user login password #3

Closed

Changed the Id according to naming convention

51f00dd

Ni3verma requested changes Jun 24, 2021

View reviewed changes

.idea/gradle.xml Outdated Show resolved Hide resolved

Merge branch 'master' of https://github.com/Ni3verma/Safe-Box into fe…

4d77605

…ature/add-hint

Calling repo method in viewmodel

c2a0211

Ni3verma requested changes Jul 6, 2021

View reviewed changes

app/src/main/java/com/andryoga/safebox/data/db/secureDao/UserDetailsDaoSecure.kt Outdated Show resolved Hide resolved

Bhawna-Ad added 2 commits July 6, 2021 12:44

Added functionality to display hint in login fragment

bcdd5e4

Merge branch 'master' of https://github.com/Bhawna-Ad/Safe-Box into f…

b4db97b

…eature/add-hint � Conflicts: � app/src/main/java/com/andryoga/safebox/ui/common/Utils.kt

Ni3verma requested changes Jul 6, 2021

View reviewed changes

app/src/main/java/com/andryoga/safebox/data/db/secureDao/UserDetailsDaoSecure.kt Outdated Show resolved Hide resolved

Ni3verma requested changes Jul 6, 2021

View reviewed changes

Made the required changes

b02a3e9

Ni3verma requested changes Jul 6, 2021

View reviewed changes

app/src/main/java/com/andryoga/safebox/data/db/secureDao/UserDetailsDaoSecure.kt Outdated Show resolved Hide resolved

Bhawna-Ad added 2 commits July 6, 2021 14:00

Updated the code

2e40572

Display hint in login screen

4141235

Ni3verma requested changes Jul 7, 2021

View reviewed changes

app/src/main/java/com/andryoga/safebox/data/repository/UserDetailsRepositoryImpl.kt Outdated Show resolved Hide resolved

Updated the code

c56e996

Ni3verma reviewed Jul 7, 2021

View reviewed changes

Bhawna-Ad added 7 commits July 9, 2021 13:06

Merge branch 'master' of https://github.com/Bhawna-Ad/Safe-Box into f…

00837ac

…eature/add-hint

Added validation rule for hint length

93f5530

Merge branch 'master' of https://github.com/Bhawna-Ad/Safe-Box into f…

6e0244e

…eature/add-hint � Conflicts: � app/src/main/java/com/andryoga/safebox/ui/common/Utils.kt

Merge branch 'master' of https://github.com/Bhawna-Ad/Safe-Box into f…

aea0f3b

…eature/add-hint

Merge branch 'master' of https://github.com/Bhawna-Ad/Safe-Box into f…

582c9f9

…eature/add-hint

Merge branch 'master' of https://github.com/Bhawna-Ad/Safe-Box into f…

2efc33b

…eature/add-hint

Added validation check for hint

62bd890

Ni3verma requested changes Jul 19, 2021

View reviewed changes

Fixed issues with hint error

a5b95a5

Ni3verma requested changes Jul 19, 2021

View reviewed changes

app/src/main/java/com/andryoga/safebox/ui/view/chooseMasterPswrd/ChooseMasterPswrdFragment.kt Outdated Show resolved Hide resolved

handling hint validation

ab901fe

Signed-off-by: Nitin Verma <[email protected]>

Bhawna-Ad marked this pull request as ready for review July 25, 2021 13:05

doing validation in background

7620792

Signed-off-by: Nitin Verma <[email protected]>

Ni3verma approved these changes Jul 29, 2021

View reviewed changes

Ni3verma merged commit 3a35079 into Ni3verma:master Jul 29, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hint functionality for user password #18

Hint functionality for user password #18

Bhawna-Ad commented Jun 23, 2021 •

edited

Loading

Ni3verma commented Jun 23, 2021

Bhawna-Ad commented Jun 23, 2021

Ni3verma commented Jun 23, 2021

Bhawna-Ad commented Jun 23, 2021 •

edited

Loading

Ni3verma commented Jun 23, 2021

Bhawna-Ad commented Jun 23, 2021

Ni3verma left a comment

Ni3verma commented Jun 23, 2021

Bhawna-Ad commented Jun 24, 2021

Ni3verma commented Jun 24, 2021

Bhawna-Ad commented Jun 24, 2021

Ni3verma left a comment

Ni3verma commented Jun 24, 2021

Bhawna-Ad commented Jun 24, 2021

Ni3verma commented Jun 24, 2021

Bhawna-Ad commented Jun 24, 2021

Ni3verma commented Jun 24, 2021

Bhawna-Ad commented Jun 24, 2021

Ni3verma left a comment

Ni3verma left a comment

Ni3verma left a comment

Ni3verma left a comment

Ni3verma left a comment

Ni3verma left a comment

Ni3verma commented Jul 29, 2021

Bhawna-Ad commented Jul 29, 2021

Hint functionality for user password #18

Hint functionality for user password #18

Conversation

Bhawna-Ad commented Jun 23, 2021 • edited Loading

Description

Type of change

Code quality checklist

Ni3verma commented Jun 23, 2021

Bhawna-Ad commented Jun 23, 2021

Ni3verma commented Jun 23, 2021

Bhawna-Ad commented Jun 23, 2021 • edited Loading

Ni3verma commented Jun 23, 2021

Bhawna-Ad commented Jun 23, 2021

Ni3verma left a comment

Choose a reason for hiding this comment

Ni3verma commented Jun 23, 2021

Bhawna-Ad commented Jun 24, 2021

Ni3verma commented Jun 24, 2021

Bhawna-Ad commented Jun 24, 2021

Ni3verma left a comment

Choose a reason for hiding this comment

Ni3verma commented Jun 24, 2021

Bhawna-Ad commented Jun 24, 2021

Ni3verma commented Jun 24, 2021

Bhawna-Ad commented Jun 24, 2021

Ni3verma commented Jun 24, 2021

Bhawna-Ad commented Jun 24, 2021

Ni3verma left a comment

Choose a reason for hiding this comment

Ni3verma left a comment

Choose a reason for hiding this comment

Ni3verma left a comment

Choose a reason for hiding this comment

Ni3verma left a comment

Choose a reason for hiding this comment

Ni3verma left a comment

Choose a reason for hiding this comment

Ni3verma left a comment

Choose a reason for hiding this comment

Ni3verma commented Jul 29, 2021

Bhawna-Ad commented Jul 29, 2021

Bhawna-Ad commented Jun 23, 2021 •

edited

Loading

Bhawna-Ad commented Jun 23, 2021 •

edited

Loading